Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools_rust from install requirement #5779

Merged
merged 2 commits into from Feb 8, 2021

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Feb 8, 2021

setuptools_rust is only required for building cryptography.

Fixes: #5778
Signed-off-by: Christian Heimes cheimes@redhat.com

setuptools_rust is only required for building cryptography.

Fixes: pyca#5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@alex
Copy link
Member

alex commented Feb 8, 2021

Heh, looks like this broke the docs tox build, which was relying on this being implicitly installed, Can you fix that and then we can merg?

@tiran
Copy link
Contributor Author

tiran commented Feb 8, 2021

Suggestions? I could add setuptools_rust to tox.ini, but feels like a hack.

@alex
Copy link
Member

alex commented Feb 8, 2021

You could add a special extras_require with it and specify that for that build. That seems good enough to me and reduces most of the duplication

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran mentioned this pull request Feb 8, 2021
@alex alex merged commit 048f7c6 into pyca:master Feb 8, 2021
tiran added a commit to tiran/cryptography that referenced this pull request Feb 8, 2021
* Remove setuptools_rust from install requirement

setuptools_rust is only required for building cryptography.

Fixes: pyca#5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>

* sdist needs setuptools_rust

Signed-off-by: Christian Heimes <cheimes@redhat.com>
reaperhulk pushed a commit that referenced this pull request Feb 8, 2021
* Remove setuptools_rust from install requirement

setuptools_rust is only required for building cryptography.

Fixes: #5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>

* sdist needs setuptools_rust

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cryptography 3.4 should not have an install_requires on setuptools_rust
2 participants