Added tls bindings for new OpenSSL APIs #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
tls-bindings
branch
3 times, most recently
from
fd3e6c0
to
ffc4f9b
Compare
reaperhulk
approved these changes
Dec 1, 2020
|
@reaperhulk @alex I had this marked as draft due to a lack of suitable tests for the I'm not positive how you guys handle this, but is there any intention to add tests for this? |
|
No, we don't generally add tests for bindings. |
|
ah. That would have simplified things greatly. Good to know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5379
closes #5483