Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.10] Revert the addition of the GIL check feature #4432

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[v2.10] Revert the addition of the GIL check feature #4432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3509fc0
Revert the GIL check
EthanSteinberg Dec 28, 2022
8cbae86
Update include/pybind11/detail/common.h
henryiii Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/pybind11/detail/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ PYBIND11_WARNING_POP
&& defined(_MSC_VER)) /* PyPy Windows: pytest hangs indefinitely at the end of the \
process (see PR #4268) */ \
&& !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF)
# define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF
// TODO: Actually enable the following define in the 2.11 release
henryiii marked this conversation as resolved.
Show resolved Hide resolved
// define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF
#endif

// #define PYBIND11_STR_LEGACY_PERMISSIVE
Expand Down