Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error reporting for inc_ref GIL failures #4427

Merged
merged 5 commits into from Dec 30, 2022
Merged

Improve the error reporting for inc_ref GIL failures #4427

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb10138
First
EthanSteinberg Dec 27, 2022
c615629
Fixs
EthanSteinberg Dec 28, 2022
8287490
Improve
EthanSteinberg Dec 28, 2022
db38f69
Additional assertions comment
EthanSteinberg Dec 28, 2022
e00557c
Improve docs
EthanSteinberg Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/advanced/misc.rst
View file
Open in desktop
Expand Up @@ -142,6 +142,8 @@ following checklist.
destructors can sometimes get invoked in weird and unexpected circumstances as a result
of exceptions.

EthanSteinberg marked this conversation as resolved.
Show resolved Hide resolved
- You should try running your code in a debug build. That will enable additional assertions
within pybind11 that can throw exceptions on some GIL errors, in particular during reference counting operations.
EthanSteinberg marked this conversation as resolved.
Show resolved Hide resolved

Binding sequence data types, iterators, the slicing protocol, etc.
==================================================================
Expand Down