change restrt to restart; deprecate restrt #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 82.39% 82.23% -0.16%
==========================================
Files 83 83
Lines 12454 12479 +25
Branches 1884 1892 +8
==========================================
+ Hits 10261 10262 +1
- Misses 1606 1626 +20
- Partials 587 591 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lukeolson
requested review from
bensworth and
jbschroder
and removed request for
bensworth
jbschroder
reviewed
Oct 27, 2023
pyamg/krylov/_fgmres.py
Outdated
| @@ -108,6 +110,15 @@ def fgmres(A, b, x0=None, tol=1e-5, | |||
| http://www-users.cs.umn.edu/~saad/books.html | |||
|
|
|||
| """ | |||
| if restrt is None: | |||
| restrt = restart | |||
There was a problem hiding this comment.
can this be a pass, and not restrt = restart ?
There was a problem hiding this comment.
Good catch; I think it should be flipped.
jbschroder
reviewed
Oct 27, 2023
pyamg/krylov/_fgmres.py
Outdated
| restrt = restart | ||
| elif restart is not None: | ||
| raise ValueError('Only use restart, not restrt (deprecated).') | ||
| else: |
There was a problem hiding this comment.
should we also set restart=restrt here in the final else?
If so, then we'd probably need to change this also in all the else statements in the other routines, too
jbschroder
reviewed
Oct 31, 2023
| @@ -108,6 +110,14 @@ def fgmres(A, b, x0=None, tol=1e-5, | |||
| http://www-users.cs.umn.edu/~saad/books.html | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
Yes, I think this looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restrtis deprecated in SciPy 1.10.0: https://docs.scipy.org/doc/scipy/release/1.10.0-notes.htmlThis follows the approach in scipy/scipy#16392
Fixes #395