Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect camelot in pypdf_table_extraction namespace #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

foarsitter
Copy link
Collaborator

This is the elaboration of #9 and the first step in rebranding.

I copied the file structure to /pypdf_table_extraction and imported all the objects from camelot where needed. This way I tried to achieve to be completely backwards compatible.

from camelot.backends.poppler_backend import PopplerBackend
from pypdf_table_extraction.backends.poppler_backend import PopplerBackend

from camelot.handlers import Lattice,Stream
from pypdf_table_extraction.parsers import Lattice,Stream

Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Maybe put line end at test_rename.py 😉

@foarsitter
Copy link
Collaborator Author

@MartinThoma can I have your opinion here?

@@ -55,6 +56,7 @@ myst-parser = {version = ">=0.16.1"}

[tool.poetry.scripts]
camelot = "camelot.__main__:main"
table_extraction = "pypdf_table_extraction.__main__:main"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to do pdf_table_extraction or pypdf_table_extraction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants