Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ambiguous translated references #2558

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Mar 29, 2024

  1. BUG: Ambiguous translated references (1/2)

    id(obj) can and will hit the same value for different objects, if they do not exist at the same time. In CPython, its just a memory address. When that collission occurs, PdfWriter when asked to insert a page from one PdfReader object may silently confuse it with one from a since-deleted PdfReader object, thus corrupting output in not-easily-noticed ways.
    
    Replacing dict[id(obj)] with dict[weakref(obj)] should suffice, as we do not replace entries - we only ever insert or delete.
    biredel committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2b7619f View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Python 3.7 (EoL) syntax

    biredel committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    1484610 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03e8b81 View commit details
    Browse the repository at this point in the history