MAINT: Change the positions of the calls of the visitor-function #2364
+109
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the text-visitor-function had been called at each change of the output.
But this can lead to wrong coordinates because the output may sent after changing the text-matrix for the next text.
As an example have a look at resources/Sample_Td-matrix.pdf: The text_matrix is computed correctly at the Td-operations but the text had been sent after applying the next transformation.
In this pull request the texts are sent inside the TJ and Tj operations.
This may lead to sending letters instead of words:
``` x=264.53, y=403.13, text='M'
x=264.53, y=403.13, text='etad'
x=264.53, y=403.13, text='ata'
x=307.85, y=403.13, text=' '
```
Therefore there is a second commit which introduces a temporarily visitor inside the processing of TJ.
The temp visitor ist used to collect the letters of TJ which will be sent after processing of TJ.
When setting the temp visitor the original parameter is manipulated. I don't know if this is bad style in python.
In case of bad style a local variable current_text_visitor may be introduced.
See also issue #1377. I haven't checked if #1377 had the Td-matrix-problem or the one to be solved by this PR.
--
This PR is a copy of #1389
The PR#1389 was made a long time ago (before we renamed to pypdf),
but it seems still valuable.
This PR migrated the changes to the new codebase. Full credit
to rogmann for all of the changes.
Co-authored-by: rogmann <github@rogmann.org>
Closed
MartinThoma
added
the
workflow-advanced-text-extraction
stefan6419846
added
the
needs-rebase
|
@MartinThoma Have there been any further plans regarding a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the text-visitor-function had been called at each change of the output. But this can lead to wrong coordinates because the output may sent after changing the text-matrix for the next text. As an example have a look at resources/Sample_Td-matrix.pdf: The text_matrix is computed correctly at the Td-operations but the text had been sent after applying the next transformation.
In this pull request the texts are sent inside the TJ and Tj operations. This may lead to sending letters instead of words:
Therefore there is a second commit which introduces a temporarily visitor inside the processing of TJ. The temp visitor ist used to collect the letters of TJ which will be sent after processing of TJ. When setting the temp visitor the original parameter is manipulated. I don't know if this is bad style in python. In case of bad style a local variable current_text_visitor may be introduced.
See also issue #1377. I haven't checked if #1377 had the Td-matrix-problem or the one to be solved by this PR.
--
This PR is a copy of #1389 The PR#1389 was made a long time ago (before we renamed to pypdf), but it seems still valuable.
This PR migrated the changes to the new codebase. Full credit to rogmann for all of the changes.