Custom implementation of warnings.formatwarning removed #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask why this pull request was never merged? I'm running into same issues with custom formatwarning interference, and it looks like the problem has already been solved, but not committed to master? |
|
@uberparkhill because the project has been essentially unmaintained for a long time, and formally acknowledged as so in 2018 (see #477) |
MartinThoma
added
the
Tiny
|
Hey, I'm sorry it's been such a long time. Would you mind to fix the merge conflicts (or open a new PR) so that CI runs? |
MartinThoma
added
the
needs-test
|
I've added this to #752 - I definitely want to merge this, but it might break existing users code. Hence only in PyPDF2 2.0 |
|
This change was incorporated in the PyPDF2 2.0.0 release. Thank you for your contributing to PyPDF2 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom implementation of formatwarning interfering with other modules removed as stated in #67