Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: position ➔ page_number in Merger.merge #1482

Merged
merged 22 commits into from Dec 10, 2022
Merged

MAINT: position ➔ page_number in Merger.merge #1482

merged 22 commits into from Dec 10, 2022

Commits on Dec 10, 2022

  1. MAINT: use 'page_number' instead of 'position'

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    6035f37 View commit details
    Browse the repository at this point in the history

  2. adjusted the argument order for merge calls

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    e102b1a View commit details
    Browse the repository at this point in the history

  3. adjusted argument order for merge call as well

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    2257e49 View commit details
    Browse the repository at this point in the history

  4. MAINT: use 'page_destination' instead of 'dest'

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    dd4443a View commit details
    Browse the repository at this point in the history

  5. MAINT: use 'user_password' instead of 'user_pwd'. fixed corresponding… 

    … test as well
    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    c1f6708 View commit details
    Browse the repository at this point in the history

  6. added the changes to the migration guide

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    d6d2f72 View commit details
    Browse the repository at this point in the history

  7. should be linted now

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    bd939dd View commit details
    Browse the repository at this point in the history

  8. reverted the order of the arguments, possible workaround?

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    30fe431 View commit details
    Browse the repository at this point in the history

  9. reverted back the argument orders everywhere it was changed

    @Infus3d
    Infus3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    2c1a3af View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into 1187-consistent-method-keywords

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    1783fb7 View commit details
    Browse the repository at this point in the history

  11. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    918c681 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    fb54699 View commit details
    Browse the repository at this point in the history

  13. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    9c1f153 View commit details
    Browse the repository at this point in the history

  14. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    ff08902 View commit details
    Browse the repository at this point in the history

  15. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    188d3d0 View commit details
    Browse the repository at this point in the history

  16. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b3e76fb View commit details
    Browse the repository at this point in the history

  17. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    ea36097 View commit details
    Browse the repository at this point in the history

  18. Update PyPDF2/_writer.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    9e75a49 View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b4a03a7 View commit details
    Browse the repository at this point in the history

  20. Apply suggestions from code review

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    6717709 View commit details
    Browse the repository at this point in the history

  21. Apply suggestions from code review

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    7de7c4b View commit details
    Browse the repository at this point in the history

  22. Update PyPDF2/_merger.py

    @MartinThoma
    MartinThoma committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    3d1deb2 View commit details
    Browse the repository at this point in the history