Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to extract gray scale images #1460

Merged
merged 4 commits into from Dec 9, 2022
Merged

Add support to extract gray scale images #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
410ad78
Add support to extract gray scale images
joeywang4 Nov 30, 2022
84919b4
Fix whitespaces for tests
joeywang4 Nov 30, 2022
62e88e2
Add indexed gray image test file and update lookup len check
joeywang4 Dec 7, 2022
6efa8a6
Remove test file and update test file path
joeywang4 Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion PyPDF2/filters.py
View file
Open in desktop
Expand Up @@ -602,10 +602,12 @@ def _xobj_to_image(x_object_obj: Dict[str, Any]) -> Tuple[Optional[str], bytes]:
from .generic import ByteStringObject

if isinstance(lookup, ByteStringObject):
if base == ColorSpaces.DEVICE_GRAY and len(lookup) == hival + 1:
lookup = b"".join([lookup[i:i + 1] * 3 for i in range(len(lookup))])
img.putpalette(lookup)
else:
img.putpalette(lookup.get_data())
img = img.convert("RGB")
img = img.convert("L" if base == ColorSpaces.DEVICE_GRAY else "RGB")
if G.S_MASK in x_object_obj: # add alpha channel
alpha = Image.frombytes("L", size, x_object_obj[G.S_MASK].get_data())
img.putalpha(alpha)
Expand Down
3 changes: 2 additions & 1 deletion tests/test_reader.py
View file
Open in desktop
Expand Up @@ -185,6 +185,7 @@ def test_get_outline(src, outline_elements):
marks=pytest.mark.xfail(reason="broken image extraction"),
),
("imagemagick-CCITTFaxDecode.pdf", ["Im0.tiff"]),
(SAMPLE_ROOT / "019-grayscale-image/grayscale-image.pdf", ["X0.png"]),
],
)
def test_get_images(src, expected_images):
Expand All @@ -204,7 +205,7 @@ def test_get_images(src, expected_images):
for image, expected_image in zip(images_extracted, expected_images):
assert image.name == expected_image
try:
fn = f"test-out-{src}-{image.name}"
fn = f"{src}-test-out-{image.name}"
with open(fn, "wb") as fp:
fp.write(image.data)
assert (
Expand Down