TST: Rewrite JS tests from unittest to pytest (#746)

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>

.github/workflows/unit-tests.yaml

@@ -48,4 +48,4 @@ jobs:
 
     - name: Test with pytest
       run: |
-        pytest Tests/tests.py Tests --cov --cov-report term-missing -vv
+        pytest Tests --cov --cov-report term-missing -vv

Makefile

@@ -14,4 +14,4 @@ clean:
 	rm -rf Tests/__pycache__ PyPDF2/__pycache__ Image9.png htmlcov docs/_build dist dont_commit_merged.pdf dont_commit_writer.pdf PyPDF2.egg-info PyPDF2_pdfLocation.txt
 
 test:
-	pytest Tests/tests.py Tests --cov --cov-report term-missing -vv --cov-report html
+	pytest Tests --cov --cov-report term-missing -vv --cov-report html

Tests/test_javascript.py

@@ -0,0 +1,44 @@
+import os
+import pytest
+
+from PyPDF2 import PdfFileReader, PdfFileWriter
+
+# Configure path environment
+TESTS_ROOT = os.path.abspath(os.path.dirname(__file__))
+PROJECT_ROOT = os.path.dirname(TESTS_ROOT)
+RESOURCE_ROOT = os.path.join(PROJECT_ROOT, "Resources")
+
+@pytest.fixture
+def pdf_file_writer():
+    ipdf = PdfFileReader(os.path.join(RESOURCE_ROOT, "crazyones.pdf"))
+    pdf_file_writer = PdfFileWriter()
+    pdf_file_writer.appendPagesFromReader(ipdf)
+    yield pdf_file_writer
+
+def test_add_js(pdf_file_writer):
+    pdf_file_writer.addJS(
+        "this.print({bUI:true,bSilent:false,bShrinkToFit:true});"
+    )
+
+    assert "/Names" in pdf_file_writer._root_object, "addJS should add a name catalog in the root object."
+    assert "/JavaScript" in pdf_file_writer._root_object["/Names"], "addJS should add a JavaScript name tree under the name catalog."
+    assert "/OpenAction" in pdf_file_writer._root_object, "addJS should add an OpenAction to the catalog."
+
+def test_overwrite_js(pdf_file_writer):
+    def get_javascript_name():
+        assert "/Names" in pdf_file_writer._root_object
+        assert "/JavaScript" in pdf_file_writer._root_object["/Names"]
+        assert "/Names" in pdf_file_writer._root_object["/Names"]["/JavaScript"]
+        return pdf_file_writer._root_object["/Names"]["/JavaScript"]["/Names"][0]
+
+    pdf_file_writer.addJS(
+        "this.print({bUI:true,bSilent:false,bShrinkToFit:true});"
+    )
+    first_js = get_javascript_name()
+
+    pdf_file_writer.addJS(
+        "this.print({bUI:true,bSilent:false,bShrinkToFit:true});"
+    )
+    second_js = get_javascript_name()
+
+    assert first_js != second_js, "addJS should overwrite the previous script in the catalog."

tox.ini

@@ -7,4 +7,4 @@ deps =
 	pillow
 	pytest
 	pytest-cov
-commands = pytest Tests/tests.py Tests --cov --cov-report term-missing -vv
+commands = pytest Tests --cov --cov-report term-missing -vv