Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print headers on page break #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shoaib-moeen
Copy link

No description provided.

@Lucas-C
Copy link
Member

Lucas-C commented May 1, 2024

Hi @shoaib-moeen

Note that the table headers already split over page breaks:

Could you please provide a minimal code snippet reproducing the problem that you are facing? 🙂

@shoaib-moeen
Copy link
Author

shoaib-moeen commented May 1, 2024

Hi @Lucas-C ,

Problem was when a single row breaks the page due to very long text it didn't print headers on the next page. It is related to issue #1142 . For now my usage was really limited to the headers not being displayed.

@Lucas-C
Copy link
Member

Lucas-C commented May 3, 2024

Problem was when a single row breaks the page due to very long text it didn't print headers on the next page. It is related to issue #1142 . For now my usage was really limited to the headers not being displayed.

Alright.
Could you maybe provide some minimal code reproducing your problem? 🙂
cf. https://stackoverflow.com/help/minimal-reproducible-example
Such minimal code will be need to craft a unit test, which is mandatory as part of Pull Requests altering fpdf2 source code.

@@ -501,6 +501,7 @@ def _render_table_cell(
wrapmode=self._wrapmode,
padding=padding,
link=cell.link,
page_break_buffer=10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no "magical numbers" like that in the code.
How did you arrive at exactly this size?
Are you aware that size specifications are relative to the document units? If someone uses inches as document units, this turns into half a page!

@Lucas-C
Copy link
Member

Lucas-C commented May 24, 2024

Hi!

Just a quick update about this: @shoaib-moeen are you still willing to work on this feature?
If you don't, or do not have time for this anymore, that totally fine! 🙂
If so we will just close this PR.

Also, if you need feedback or help on this PR, please tell us! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants