Pattern feature implementation #1041
Draft
+430
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, squares, and circles in eitheran outer shape of a rectangle or a circle
Lucas-C
reviewed
Dec 5, 2023
fpdf/drawing.py
Outdated
Comment on lines
1269
to
1278
| @property | ||
| def fill_pattern(self): | ||
| """The desired fill pattern for this path/group.""" | ||
| pass | ||
|
|
||
| @fill_pattern.setter | ||
| def fill_pattern(self, new): | ||
| """The desired fill pattern for this path/group.""" | ||
| pass | ||
|
|
There was a problem hiding this comment.
Those getter / setter do nothing, are in fact not really needed if the property you introduced is public (no leading underscore)
|
Thank you for initiating a PR 👍 I converted it into a draft for now, as this seems still incomplete. |
Sorry! I should have made it a draft thank you! |
…nd circles in eitheran outer shape of a rectangle or a circle
…daouddd/fpdf2 into Pattern-Feature-Implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement the Pattern Feature described by Issue #790.
Our current approach is to follow the same pipeline as set_font(). We have broken down the task into the following subtasks:
Creating PDFpattern class
Adding the set_fill_pattern method
Creating PDFpattern objects and adding them to the PDF Pattern dictionary
Serializing the call to a pattern
Documentation
Tests
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.