Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-37252) discontinue use of logback-access #19

Merged
merged 1 commit into from Nov 29, 2023

Conversation

jonathannewman
Copy link
Contributor

This disables the use of logback-access because logback-access is not compatible with Jetty 10. See jetty/jetty.project#5996

This changes the implementation to use a CustomRequestLog in jetty with the SLF4JLogWriter until a better solution can be determined. This means that logging won't obey the logback-access configuration specified.

This disables the use of logback-access because logback-access is not
compatible with Jetty 10.  See jetty/jetty.project#5996

This changes the implementation to use a CustomRequestLog in jetty with the SLF4JLogWriter
until a better solution can be determined.  This means that logging won't obey the
logback-access configuration specified.
@jonathannewman jonathannewman requested review from a team as code owners November 29, 2023 17:16
Copy link
Contributor

@steveax steveax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveax steveax merged commit 6e4ceed into puppetlabs:main Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants