Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(packaging) Bump shared rubygem versions #349

Merged
merged 1 commit into from Jul 2, 2020

Conversation

lucywyman
Copy link
Contributor

@lucywyman lucywyman commented Jun 17, 2020

This updates rubygems used by multiple projects to their latest versions.

@puppetlabs/night-s-watch Need approval for bumping all three gems

@puppetlabs/installer-and-management Need approval for ffi

@puppetlabs/pdk Need approval for ffi

@lucywyman lucywyman requested a review from a team June 17, 2020 18:11
@lucywyman lucywyman requested a review from a team as a code owner June 17, 2020 18:11
@lucywyman lucywyman changed the title (maint) Bump shared rubygem versions (packaging) Bump shared rubygem versions Jun 17, 2020
@scotje
Copy link
Contributor

scotje commented Jun 17, 2020

Going to build a pdk-runtime package from this and then run it through our tests.

@gimmyxd
Copy link
Contributor

gimmyxd commented Jun 26, 2020

Jenkins please test this with puppet-agent master on aix61-POWERfa,solaris10-64a,windows2012r2-64a

Copy link
Contributor

@gimmyxd gimmyxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good form agent side, run an ad-hoc pipeline and tests have passed.

This updates rubygems used by multiple projects to their latest versions.
@lucywyman
Copy link
Contributor Author

Just as a heads up, PDK had trouble verifying a build due to a Litmus dependency failing to compile. We're waiting on that issue to get resolved so that they can ensure this works.

Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this through an ad-hoc PDK build so I think it's good to go.

@lucywyman lucywyman merged commit f83bcfb into puppetlabs:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants