(packaging) Bump shared rubygem component versions to latest #313
Conversation
lucywyman
force-pushed
the
bump-common-gems
branch
from
efb4944
to
766792d
Compare
| pkg.version '1.9.25' | ||
| pkg.md5sum "e8923807b970643d9e356a65038769ac" | ||
| pkg.version '1.12.2' | ||
| pkg.md5sum "28dc3d1294a04b728d24ba025e331b13" |
There was a problem hiding this comment.
I know we've had some challenges with "ffi" versions in the past in PDK, I'll see if I can make an ad-hoc build with this PR and validate this works.
There was a problem hiding this comment.
Same with bolt on OSX. might be worth seeing that as well with this ffi
There was a problem hiding this comment.
@lucywyman we need to update the md5 sums for the windows version of the ffi gem a little further down in the file.
There was a problem hiding this comment.
@scotje Apologies, I dropped your commit since newer ffi breaks things on Windows (see comments below), so there's no need to update the checksums.
This updates rubygem component versions to their latest for gems that are shared across multiple projects.
lucywyman
force-pushed
the
bump-common-gems
branch
from
766792d
to
a79fbce
Compare
|
Was able to successfully build puppet-runtime for agent-master, also triggering a puppet-agent build with these changes. |
|
We're encountering some valid failures with the ffi gem installation on Solaris, so please do not merge this just yet. |
|
There are also vaild pxp-agent test failures on Windows: Traced that to chef/win32-service#70 We should hold back the FFI gem for Windows. |
Pin ffi on Windows due to pxp-agent tests failing. Even though they are deprecation warnings, having output on stderr may break things in unexpected ways. See: chef/win32-service#70
GabrielNagy
force-pushed
the
bump-common-gems
branch
from
006523a
to
ed404fa
Compare
|
Still working to test a PDK build, the |
|
If you can get bolt builds on all the osx platforms them i'm good. We only build bolt-server for master platforms. i was just noting that I had previously had problems building ffi > 1.9.25 on osx platforms. |
|
👍 Didn't find any conflicts for installer team projects. |
This updates rubygem component versions to their latest for gems that
are shared across multiple projects.
Specifically the @puppetlabs/installer-and-management team includes:
bcrypt_pbkdf
ffi
gettext-setup
locale
multi_json
The puppet-agent package includes:
concurrent-ruby
ffi
gettext-setup
locale
multi_json
The @puppetlabs/pdk package includes:
ffi
gettext-setup