Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Use Ruby 2.5 on Travis for PDK as a library tests #849

Merged
merged 1 commit into from Feb 13, 2020

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Feb 12, 2020

Concurrent-ruby 1.1.6 has a strange thread timing issue under Ruby 2.4 and the
spec/unit/pdk/analytics/util_spec.rb file. Causing facter to error with
"cannot alloc thread" which then halts the test. It doesn't occur on Appveyor
(Windows) or the regular rspec under Ruby 2.4 testing. So just use Ruby 2.5
instead.

@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage remained the same at 90.404% when pulling a9ae477 on glennsarti:test-concurrent into fde65a3 on puppetlabs:master.

Concurrent-ruby 1.1.6 has a strange thread timing issue under Ruby 2.4 and the
spec/unit/pdk/analytics/util_spec.rb file. Causing facter to error with
"cannot alloc thread" which then halts the test. It doesn't occur on Appveyor
(Windows) or the regular rspec under Ruby 2.4 testing. So just use Ruby 2.5
instead.
@glennsarti glennsarti changed the title {WIP} Test Travis (maint) Use Ruby 2.5 on Travis for PDK as a library tests Feb 12, 2020
@glennsarti glennsarti self-assigned this Feb 12, 2020
@rodjek
Copy link
Contributor

rodjek commented Feb 12, 2020

@DavidS noticed an issue with concurrent-ruby 1.1.6 on ruby 2.5 ruby-concurrency/concurrent-ruby#849, perhaps for now we should just pin to the previous version of concurrent-ruby instead?

@glennsarti
Copy link
Contributor Author

I thought about that too and initially tested it (works fine). I decided to not go down that path:

  1. The regular ruby 2.4 specs work fine, so it's definitely something to do with the Travis config.
  2. Ruby 2.5.5 is working (so far, which is what RUBY_VER=2.5 is picking up). David said it broke on Ruby 2.5.1.
  3. The failing test cell is only testing that we can run the _spec.rb files individually, not so much that the tests actually work. So I went the route of smallest change (one travis cell as opposed to pinning the Gem for everyone)
  4. Also means we'll pick up the new updated gem when (/if) it gets released

@glennsarti glennsarti merged commit 942885b into puppetlabs:master Feb 13, 2020
@rodjek rodjek added this to the February 2020 milestone Feb 26, 2020
@glennsarti glennsarti deleted the test-concurrent branch March 5, 2020 04:57
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants