-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for faraday 2.x #98
Conversation
The tests only run on 2.5 and newer, so we should not claim to support Ruby 2.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking a look a this as well if you don't mind.
@@ -18,10 +18,9 @@ Gem::Specification.new do |spec| | |||
spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
spec.require_paths = ["lib"] | |||
|
|||
spec.required_ruby_version = '>= 2.4.0' | |||
spec.required_ruby_version = '>= 2.5.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faraday 2.0 only supports Ruby 2.6+ so claiming 2.5 support feels incorrect.
|
||
spec.add_runtime_dependency "faraday", "~> 1.3" | ||
spec.add_runtime_dependency "faraday_middleware", "~> 1.0" | ||
spec.add_runtime_dependency "faraday", ">= 2.0.0", "< 3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels simpler
spec.add_runtime_dependency "faraday", ">= 2.0.0", "< 3.0.0" | |
spec.add_runtime_dependency "faraday", "~> 2.0" |
superseded by #99 |
No description provided.