(PF-2437) Prepend 'Bearer' string to authorization #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authorized requests to the Forge require an authorization header of "Bearer <api-key>". This changes the connection process so that if a user has set `PuppetForge::Connection.authorization` to something that looks like a Forge API key (a 64-character hex string), it automatically prepends the "Bearer " string. This will not take effect if the user has already prepended "Bearer " themselves, or if the authorization value doesn't fit the expected key format. Also updates the README with basic information on authorization.
caseywilliams
force-pushed
the
PF-2437/prepend-bearer
branch
from
7f67725
to
997124e
Compare
|
(Force-pushed to update the commit message) |
|
will this affect the Artifactory token support in https://github.com/puppetlabs/r10k/blob/233b22fa516413685646d0ae0bfaa6769ee31003/doc/dynamic-environments/configuration.mkd#authorization_token? |
|
If a user has already prepended |
|
Also @binford2k, fwiw, you would have had to prepend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorized requests to the Forge require an authorization header of
"Bearer <api-key>". This changes the connection process so that if a
user has set
PuppetForge::Connection.authorizationto something thatlooks like a Forge API key (a 64-character hex string), it automatically
prepends the "Bearer " string. This will not take effect if the user
has already prepended "Bearer " themselves, or if the authorization
value doesn't fit the expected key format.
Also updates the README with basic information on authorization.