Add LRU cache for HTTP response caching #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This commit adds a new class, PuppetForge::LruCache, that is used by PuppetForge::V3::Base to cache HTTP get responses that are returned in the PuppetForge::V3::Base#request method. This should ensure that most HTTP requests are locally cached and should improve performance and reduce load on the upstream servers. The maximum cache size defaults to 30, however it is configurable using the environment variable PUPPET_FORGE_MAX_CACHE_SIZE.
owenbeckles
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new class,
PuppetForge::LruCache, that is used byPuppetForge::V3::Baseto cache HTTP get responses that are returned in thePuppetForge::V3::Base#requestmethod. This should ensure that most HTTP requests are locally cached and should improve performance and reduce load on the upstream servers. The maximum cache size defaults to 30, however it is configurable using the environment variablePUPPET_FORGE_MAX_CACHE_SIZE.