Raise ModuleNotFound if a module is not found #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While 026e0c1 did add the exception class, it wasn't used. This avoids leaking an implementation detail. Technically this is backwards incompatible, since it requires users to change their code. It could make PuppetForge::ModuleNotFound inherit from Faraday::ResourceNotFound, but that stil leaks the implementation detail.
bastelfreak
approved these changes
Apr 28, 2023
owenbeckles
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While 026e0c1 did add the exception class, it wasn't used. This avoids leaking an implementation detail.
Technically this is backwards incompatible, since it requires users to change their code. It could make PuppetForge::ModuleNotFound inherit from Faraday::ResourceNotFound, but that stil leaks the implementation detail. It could however be split into two releases: one minor to do this + inherit and make it not inherit in a major release.