Allows the user to search by an array of endorsements #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Forge API expects a space separated list of endorsements. This feels weird from the perspective of the consumer of a library. I'd expect that implementation detail to be abstracted away. This patch allows endorsements to be specified as either the space separated list or as an array.
owenbeckles
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Forge API expects a space separated list of endorsements. This feels
weird from the perspective of the consumer of a library. I'd expect that
implementation detail to be abstracted away.
This patch allows endorsements to be specified as either the space
separated list or as an array.