Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-2291) Enable bootsnap loadpath caching #2291

Closed
wants to merge 3 commits into from
Closed

(GH-2291) Enable bootsnap loadpath caching #2291

wants to merge 3 commits into from

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Oct 27, 2020 •
edited by lucywyman

Depends on

@puppetcla
Copy link

CLA signed by all contributors.

@lucywyman lucywyman added this to 🚧 Reviewing in Bolt Kanban via automation Nov 24, 2020
@lucywyman lucywyman moved this from 🚧 Reviewing to ⚡️ Doing in Bolt Kanban Nov 24, 2020
@lucywyman lucywyman moved this from ⚡️ Doing to 📝 To Do in Bolt Kanban Nov 24, 2020
@beechtom beechtom self-assigned this Nov 25, 2020
@beechtom beechtom moved this from 📝 To Do to ⚡️ Doing in Bolt Kanban Nov 25, 2020
beechtom
beechtom reviewed Dec 1, 2020
View reviewed changes
exe/bolt Outdated Show resolved Hide resolved
@beechtom beechtom assigned jpogran and unassigned beechtom Dec 2, 2020
@jpogran jpogran force-pushed the gogobootsnap branch 2 times, most recently from d48bc69 to db740c5 Compare December 7, 2020 17:26
@jpogran jpogran mentioned this pull request Dec 7, 2020
Merged
@jpogran jpogran changed the base branch from main to 3.0 December 7, 2020 19:15
@jpogran jpogran force-pushed the gogobootsnap branch 2 times, most recently from 8634499 to 437cd98 Compare January 4, 2021 16:40
@jpogran jpogran added the Bolt 4.0 Changes and removals for Bolt 4.0 label Jan 11, 2021
jpogran added a commit to jpogran/bolt that referenced this pull request Jan 12, 2021
@jpogran
(puppetlabsGH-2291) Enable bootsnap loadpath caching
9369317 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@jpogran jpogran changed the title (WIP) Use bootsnap (GH-2291) Enable bootsnap loadpath caching Jan 12, 2021
@jpogran
Copy link
Contributor Author

jpogran commented Jan 12, 2021

target branch needs to be synced with main before merge

@lucywyman
Copy link
Contributor

Ok, 3.0 should be even with main now. I think this branch just needs a rebase.

jpogran added a commit to jpogran/bolt that referenced this pull request Jan 13, 2021
@jpogran
(puppetlabsGH-2291) Enable bootsnap loadpath caching
56cce17 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@beechtom beechtom added this to the Bolt 3.0 milestone Jan 15, 2021
beechtom
beechtom reviewed Jan 15, 2021
View reviewed changes
exe/bolt Outdated Show resolved Hide resolved
jpogran added a commit to jpogran/bolt that referenced this pull request Jan 19, 2021
@jpogran
(puppetlabsGH-2291) Enable bootsnap loadpath caching
87fa6ed 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
jpogran added a commit to jpogran/bolt that referenced this pull request Mar 5, 2021
@jpogran
(puppetlabsGH-2291) Enable bootsnap loadpath caching
dd571e8 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@jpogran jpogran force-pushed the gogobootsnap branch 2 times, most recently from 1653227 to 4e9f7ca Compare March 5, 2021 17:47
jpogran added a commit to jpogran/bolt that referenced this pull request Mar 9, 2021
@jpogran
(puppetlabsGH-2291) Enable bootsnap loadpath caching
e6a3ff0 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@beechtom beechtom removed this from the Bolt 3.0 milestone Mar 24, 2021
@lucywyman lucywyman moved this from ⚡️ Doing to 🚫 Blocked in Bolt Kanban Apr 7, 2021
lucywyman pushed a commit to lucywyman/bolt that referenced this pull request May 24, 2021
@jpogran @lucywyman
(puppetlabsGH-2291) Enable bootsnap loadpath caching
05c030d 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
lucywyman pushed a commit to lucywyman/bolt that referenced this pull request May 27, 2021
@jpogran @lucywyman
(puppetlabsGH-2291) Enable bootsnap loadpath caching
14ca387 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
beechtom pushed a commit to beechtom/bolt that referenced this pull request Jun 2, 2021
@jpogran @beechtom
(puppetlabsGH-2291) Enable bootsnap loadpath caching
afcbe1a 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@beechtom
Copy link
Contributor

Related ticket about pre-compiling the load-path-cache: Shopify/bootsnap#355

@beechtom beechtom mentioned this pull request Jun 30, 2021
Closed
beechtom added a commit to beechtom/bolt that referenced this pull request Jun 30, 2021
@beechtom
(puppetlabsGH-2291) Add bootsnap
d071825 
!no-release-note
lucywyman pushed a commit to lucywyman/bolt that referenced this pull request Aug 25, 2021
@jpogran @lucywyman
(puppetlabsGH-2291) Enable bootsnap loadpath caching
b188cf6 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lucywyman
❌ jpogran
You have signed the CLA already but the status is still pending? Let us recheck it.

@lucywyman lucywyman removed this from 🚫 Blocked in Bolt Kanban Sep 1, 2021
lucywyman pushed a commit to lucywyman/bolt that referenced this pull request Sep 10, 2021
@jpogran @lucywyman
(puppetlabsGH-2291) Enable bootsnap loadpath caching
a06725e 
!feature

* **Enable bootsnap loadpath caching** ([puppetlabs#2291](puppetlabs#2291))

   Enable bootsnap loadpath caching
lucywyman added a commit to lucywyman/bolt that referenced this pull request Sep 13, 2021
@lucywyman
(puppetlabsGH-2291) Enable Bootsnap
1dafa30 
This enables Bootsnap's compile cache for Bolt when running on Windows, which caches the compiled Ruby bytecode and YAML Messagepack format results for faster loading. When using Bootsnap we disable the load path cache, since Bolt modifies the load path from the user's environment which results in the cache being recomputed and rewritten every Bolt run, which negates any performance improvements from compilation caching.

!no-release-note
lucywyman added a commit to lucywyman/bolt that referenced this pull request Sep 13, 2021
@lucywyman
(puppetlabsGH-2291) Enable Bootsnap
9055f77 
This enables Bootsnap's compile cache for Bolt when running on Windows, which caches the compiled Ruby bytecode and YAML Messagepack format results for faster loading. When using Bootsnap we disable the load path cache, since Bolt modifies the load path from the user's environment which results in the cache being recomputed and rewritten every Bolt run, which negates any performance improvements from compilation caching.

!no-release-note
lucywyman added a commit to lucywyman/bolt that referenced this pull request Sep 13, 2021
@lucywyman
(puppetlabsGH-2291) Enable Bootsnap
b3b9d02 
This enables Bootsnap's compile cache for Bolt when running on Windows, which caches the compiled Ruby bytecode and YAML Messagepack format results for faster loading. When using Bootsnap we disable the load path cache, since Bolt modifies the load path from the user's environment which results in the cache being recomputed and rewritten every Bolt run, which negates any performance improvements from compilation caching.

!no-release-note
beechtom added a commit that referenced this pull request Sep 13, 2021
@beechtom
Merge pull request #3020 from lucywyman/gogobootsnap
d9a2834 
(GH-2291) Enable Bootsnap
@lucywyman
Copy link
Contributor

Closing in favor of #3020

@lucywyman lucywyman closed this Sep 13, 2021
beechtom added a commit that referenced this pull request Sep 14, 2021
@beechtom
Revert "(GH-2291) Enable Bootsnap"
2781135
beechtom added a commit that referenced this pull request Sep 14, 2021
@beechtom
Revert "(GH-2291) Enable Bootsnap"
27bcc42 
!no-release-note
lucywyman added a commit that referenced this pull request Sep 14, 2021
@lucywyman
Merge pull request #3024 from puppetlabs/revert-3020-gogobootsnap
dc43f6f 
Revert "(GH-2291) Enable Bootsnap"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman left review comments

@beechtom beechtom beechtom left review comments

Assignees

@jpogran jpogran

Labels
Bolt 4.0 Changes and removals for Bolt 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ship with Puppet 7
6 participants
@jpogran @puppetcla @lucywyman @beechtom @CLAassistant @hestonhoffman