(maint) remove concurrent-ruby lock #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concurrent-ruby was locked to 1.1.5 in puppetlabs#69 due to an issue in 1.1.6. A fix for that was released on concurrent-ruby-1.1.7: ruby-concurrency/concurrent-ruby#856 Recently, in puppet-runtime, concurrent-ruby was bumped to 1.1.8 https://github.com/puppetlabs/puppet-runtime/pull/446/files#diff-6393a204a090900f17b88f58f21f2b5c355271b5e8df85328a80accbc2c503e0R2 making ruby pe-ace-server unable to start: ``` -- Unit pe-ace-server.service has begun starting up. May 17 08:15:28 main-wisdom puma[15711]: /opt/puppetlabs/puppet/lib/ruby/2.5.0/rubygems/dependency.rb:312:in `to_specs’: Could not find ‘concurrent-ruby’ (= 1.1.5) - did find: [concurrent-ruby-1.1.8] (Gem::MissingSpecVersionError) ``` This commit removes the lock of concurrent-ruby as the upstream issue was fixed and release.
mcdonaldseanp
approved these changes
May 17, 2021
|
Thank you, for most changes we prefer the work be merged into the 2019.8.x branch then merged up. |
donoghuc
pushed a commit
to donoghuc/ace
that referenced
this pull request
May 17, 2021
(maint) remove concurrent-ruby lock
steveax
added a commit
that referenced
this pull request
May 26, 2021
* 2019.8.x: (maint) add changelog entry for PE-31689 (PE-31689) Don't fork in run_task endpoint Merge pull request #93 from gimmyxd/maint/relax_concurrent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concurrent-ruby was locked to 1.1.5 in #69
due to an issue in 1.1.6. A fix for that was released
in concurrent-ruby-1.1.7: ruby-concurrency/concurrent-ruby#856
Recently, in puppet-runtime, concurrent-ruby was
bumped to 1.1.8 https://github.com/puppetlabs/puppet-runtime/pull/446/files#diff-6393a204a090900f17b88f58f21f2b5c355271b5e8df85328a80accbc2c503e0R2
making ruby pe-ace-server unable to start:
This commit removes the lock of concurrent-ruby as
the upstream issue was fixed and released.