Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-27794) add a puma status app #64

Closed
wants to merge 1 commit into from
Closed

(PE-27794) add a puma status app #64

wants to merge 1 commit into from

Conversation

tkishel
Copy link
Contributor

@tkishel tkishel commented Nov 29, 2019

Depends upon puppetlabs/bolt#1452

@tkishel tkishel requested a review from a team November 29, 2019 18:11
@tkishel
Copy link
Contributor Author

tkishel commented Nov 29, 2019

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         358    358           
=====================================
  Hits          358    358
Impacted Files Coverage Δ
lib/ace/config.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8080f01...46393b4. Read the comment docs.

@tkishel
Copy link
Contributor Author

tkishel commented Dec 13, 2019

Updated POC. Smaller footprint. Requires Puma 4.3.x and related PR in Bolt.

With this commit, a puma status app (the default or ours) is loaded.
Requires Puma 4.3.x and the corresponding PE-27794 changes to bolt.
@tkishel tkishel changed the title (PE-27794) add the puma-stats app (PE-27794) add a puma status app Dec 14, 2019
@tkishel
Copy link
Contributor Author

tkishel commented Dec 18, 2019

Closing in favor of the simpler #65

@tkishel tkishel closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant