(PE-35500) Support timeout for run_task and execute_catalog #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the run_task endpoint to accept a timeout (in seconds). If the timeout is hit the task will effectively be abandoned on the target. This is accomplished by running the task execution in a thread and waiting for that thred for "timeout" seconds. If the thread has not completed by that amount of time we send a kill signal to the thread and raise a timeout error.
donoghuc
force-pushed
the
PE-35500-timeout
branch
from
6895203
to
3daef17
Compare
This commit updates the execute_catalog endpoint to accept a timeout parameter. The timeout parameter represents the number of seconds to wait before giving up on the puppet run. This is implemented by waiting "timeout" seconds for the sub-process forked for the puppet run. If the timeout is hit the sub-process will be killed.
donoghuc
force-pushed
the
PE-35500-timeout
branch
from
3daef17
to
7fe8f31
Compare
mcdonaldseanp
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.