(RE-15228) Move to travis and run against ruby 3 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a ruby 3 readyness fix. It disambiguates argument destructuring for keyword arguments.
Travis is no longer working and needs to be replaced anyway. Replace it now instead of fixing it.
(maint) Shake the dust off
Looks like making volume readable may actually be necessary. Porting over that and some other seemingly strange hacks from travis setup.
We do this separately with mend.
(maint) Allow running under ruby 3 and puppet 8
* upstream/2021.7.x: (maint) Stop running license check on pr test (maint) Port over some travis setup (maint) appease rubocop (maint) Allow running under ruby 3 and puppet 8 (maint) replace travis (broken) with github actions (maint) Update ssl fixtures (maint) Disambiguate keywork args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things:
This is in preparation to actually get some work done on PE-35500