New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove oopif expectations and fix oopif flakiness #9375
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
"testIdPattern": "[accessibility.spec]", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox"], | ||
"expectations": ["SKIP"] | ||
"expectations": ["SKIP", "TIMEOUT"] | ||
}, | ||
{ | ||
"testIdPattern": "[ariaqueryhandler.spec]", | ||
|
@@ -1175,30 +1175,6 @@ | |
"parameters": ["firefox"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[oopif.spec] OOPIF should support OOP iframes becoming normal iframes again", | ||
"platforms": ["darwin"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[oopif.spec] OOPIF should keep track of a frames OOP state", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[oopif.spec] OOPIF should wait for inner OOPIFs", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL", "TIMEOUT"] | ||
}, | ||
{ | ||
"testIdPattern": "[oopif.spec] OOPIF should track navigations within OOP iframes", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.connect should be able to connect to a browser with no page targets", | ||
"platforms": ["linux", "darwin", "win32"], | ||
|
@@ -1967,54 +1943,6 @@ | |
"parameters": ["firefox"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch can launch and close the browser", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[Connection.spec] WebDriver BiDi", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work with function shorthands", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work with unicode chars", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work right after framenavigated", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work from-inside an exposed function", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch should be able to launch Firefox", | ||
"platforms": ["darwin", "linux", "win32"], | ||
|
@@ -2029,7 +1957,7 @@ | |
}, | ||
{ | ||
"testIdPattern": "[headful.spec] headful tests HEADFUL target.page() should return a background_page", | ||
"platforms": ["win32"], | ||
"platforms": ["win32", "darwin"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
|
@@ -2075,12 +2003,6 @@ | |
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[oopif.spec]", | ||
"platforms": ["win32"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[network.spec] network \"after each\" hook for \"Same-origin set-cookie subresource\"", | ||
"platforms": ["win32"], | ||
|
@@ -2105,12 +2027,6 @@ | |
"parameters": ["chrome", "chrome-headless"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[headful.spec] headful tests HEADFUL OOPIF: should expose events within OOPIFs", | ||
"platforms": ["linux"], | ||
"parameters": ["chrome"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[waittask.spec] waittask specs Frame.waitForFunction should survive cross-process navigation", | ||
"platforms": ["darwin", "linux", "win32"], | ||
|
@@ -2128,5 +2044,71 @@ | |
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added some common failures that have been around for a while now. |
||
"testIdPattern": "[screenshot.spec] Screenshots Page.screenshot should work", | ||
"platforms": ["linux"], | ||
"parameters": ["chrome", "chrome-headless"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[tracing.spec] Tracing \"after each\" hook for \"should output a trace\"", | ||
"platforms": ["win32"], | ||
"parameters": ["chrome", "headless"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
"testIdPattern": "[tracing.spec] Tracing \"after each\" hook for \"should output a trace\"", | ||
"platforms": ["win32"], | ||
"parameters": ["chrome", "headless"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BiDi expectation should always be last. |
||
"testIdPattern": "", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP", "TIMEOUT"] | ||
}, | ||
{ | ||
"testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch can launch and close the browser", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[Connection.spec] WebDriver BiDi", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["PASS"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work with function shorthands", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work with unicode chars", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work right after framenavigated", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
}, | ||
{ | ||
"testIdPattern": "[evaluation.spec] Evaluation specs Page.evaluate should work from-inside an exposed function", | ||
"platforms": ["darwin", "linux", "win32"], | ||
"parameters": ["firefox", "webDriverBiDi"], | ||
"expectations": ["SKIP"] | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be redundant because we always get
frameDetached
event.