Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): roll to Chromium 109.0.5412.0 (r1069273) #9364

Merged
merged 7 commits into from Dec 7, 2022
Merged

feat(chromium): roll to Chromium 109.0.5412.0 (r1069273) #9364

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce25c4a
feat(chromium): roll to Chromium 109.0.5412.0 (r1069273)
Lightning00Blade Dec 2, 2022
b6ffd83
feat(chromium): fixes
Lightning00Blade Dec 6, 2022
44b39ce
feat(chromium): fixes
Lightning00Blade Dec 6, 2022
ccaae37
feat(chromium): fixes
Lightning00Blade Dec 7, 2022
1ff048b
feat(chromium): fixes
Lightning00Blade Dec 7, 2022
ed0d8b3
feat(chromium): fixes
Lightning00Blade Dec 7, 2022
14035f8
feat(chromium): fixes
Lightning00Blade Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 4 additions & 17 deletions test/src/navigation.spec.ts
View file
Open in desktop
Expand Up @@ -21,7 +21,6 @@ import {
setupTestBrowserHooks,
setupTestPageAndContextHooks,
} from './mocha-utils.js';
import os from 'os';
import {ServerResponse} from 'http';
import {HTTPRequest} from 'puppeteer-core/internal/common/HTTPRequest.js';
import {TimeoutError} from 'puppeteer';
Expand Down Expand Up @@ -153,20 +152,8 @@ describe('navigation', function () {
}
});

function getExpectedSSLCertMessage(): string {
const {headless} = getTestState();
/**
* If you are running this on pre-Catalina versions of macOS this will fail
* locally. Mac OSX Catalina outputs a different message than other
* platforms. See https://support.google.com/chrome/thread/18125056?hl=en
* for details. If you're running pre-Catalina Mac OSX this test will fail
* locally.
* In chrome-headless, the message is also different.
*/
return os.platform() === 'darwin' && headless !== 'new'
? 'net::ERR_CERT_INVALID'
: 'net::ERR_CERT_AUTHORITY_INVALID';
}
const EXPECTED_SSL_CERT_MESSAGE_REGEX =
/net::ERR_CERT_INVALID|net::ERR_CERT_AUTHORITY_INVALID/;

it('should fail when navigating to bad SSL', async () => {
const {page, httpsServer, isChrome} = getTestState();
Expand All @@ -189,7 +176,7 @@ describe('navigation', function () {
return (error = error_);
});
if (isChrome) {
expect(error.message).toContain(getExpectedSSLCertMessage());
expect(error.message).toMatch(EXPECTED_SSL_CERT_MESSAGE_REGEX);
} else {
expect(error.message).toContain('SSL_ERROR_UNKNOWN');
}
Expand All @@ -208,7 +195,7 @@ describe('navigation', function () {
return (error = error_);
});
if (isChrome) {
expect(error.message).toContain(getExpectedSSLCertMessage());
expect(error.message).toContain(EXPECTED_SSL_CERT_MESSAGE_REGEX);
OrKoN marked this conversation as resolved.
Show resolved Hide resolved
} else {
expect(error.message).toContain('SSL_ERROR_UNKNOWN');
}
Expand Down