Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(requestinterception): remove outdated note #9358

Merged
merged 2 commits into from Dec 7, 2022
Merged

docs(requestinterception): remove outdated note #9358

merged 2 commits into from Dec 7, 2022

Conversation

Androbin
Copy link
Contributor

@Androbin Androbin commented Dec 3, 2022

See #7304 @jschfflr Seems like we missed some
Thanks to @chrismdd for spotting this

@Androbin
Copy link
Contributor Author

Androbin commented Dec 3, 2022

The note used to be accurate:

async _updateProtocolCacheDisabled(): Promise<void> {
await this._client.send('Network.setCacheDisabled', {
cacheDisabled:
this._userCacheDisabled || this._protocolRequestInterceptionEnabled,
});
}

The note is no longer accurate:

#cacheDisabled(): boolean {
return this.#userCacheDisabled;
}
async #updateProtocolCacheDisabled(): Promise<void> {
await this.#client.send('Network.setCacheDisabled', {
cacheDisabled: this.#cacheDisabled(),
});
}

See #7217 for more context

@OrKoN
Copy link
Collaborator

OrKoN commented Dec 6, 2022

Could you please re-run npm run docs to regenerate MD files in this PR?

@OrKoN OrKoN enabled auto-merge (squash) December 6, 2022 18:09
@OrKoN OrKoN merged commit 1501ede into puppeteer:main Dec 7, 2022
@Androbin Androbin deleted the docs branch December 8, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants