Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import BiDi impl only if the user opts in #9335

Merged
merged 1 commit into from Nov 29, 2022
Merged

chore: import BiDi impl only if the user opts in #9335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/puppeteer-core/src/node/BrowserRunner.ts
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ import * as path from 'path';
import * as readline from 'readline';
import removeFolder from 'rimraf';
import {promisify} from 'util';
import {Connection as BiDiConnection} from '../common/bidi/Connection.js';
import type {Connection as BiDiConnection} from '../common/bidi/bidi.js';
import {Connection} from '../common/Connection.js';
import {debug} from '../common/Debug.js';
import {TimeoutError} from '../common/Errors.js';
Expand Down Expand Up @@ -262,7 +262,8 @@ export class BrowserRunner {
);
browserWSEndpoint += '/session';
const transport = await WebSocketTransport.create(browserWSEndpoint);
return new BiDiConnection(transport, slowMo);
const BiDi = await import('../common/bidi/bidi.js');
return new BiDi.Connection(transport, slowMo);
}

async setupConnection(options: {
Expand Down
4 changes: 2 additions & 2 deletions packages/puppeteer-core/src/node/FirefoxLauncher.ts
View file
Open in desktop
Expand Up @@ -2,7 +2,6 @@ import fs from 'fs';
import os from 'os';
import path from 'path';
import {Browser} from '../api/Browser.js';
import {Browser as BiDiBrowser} from '../common/bidi/Browser.js';
import {CDPBrowser} from '../common/Browser.js';
import {assert} from '../util/assert.js';
import {BrowserFetcher} from './BrowserFetcher.js';
Expand Down Expand Up @@ -133,7 +132,8 @@ export class FirefoxLauncher extends ProductLauncher {
slowMo,
preferredRevision: this.puppeteer.browserRevision,
});
browser = await BiDiBrowser.create({
const BiDi = await import('../common/bidi/bidi.js');
browser = await BiDi.Browser.create({
connection,
closeCallback: runner.close.bind(runner),
process: runner.proc,
Expand Down