docs: mention how to disable timeout for page.pdf()
#9167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
mention_disable_timeout_of_pdfoptions
branch
from
0db6a77
to
d2a4b6e
Compare
OrKoN
force-pushed
the
mention_disable_timeout_of_pdfoptions
branch
from
d2a4b6e
to
6c122cd
Compare
OrKoN
approved these changes
Dec 12, 2022
This was mentioned in the PR that adding this feature puppeteer#7508 But it has lost at puppeteer#8593. I'm not sure why this was removed, but I think this info is useful for users.
OrKoN
force-pushed
the
mention_disable_timeout_of_pdfoptions
branch
from
6c122cd
to
5ae012c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add how to disable timeout for
page.pdf().Summary
This was mentioned in the PR that adding this feature #7508 But it has lost at #8593.
I'm not sure why this was removed, but I think this info is useful for users.
Does this PR introduce a breaking change?
no