Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix builds in CI #8877

Merged
merged 1 commit into from Sep 1, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -196,6 +196,9 @@ jobs:
- name: Test bundling and installation
if: ${{ matrix.spec.name == 'Linux' }}
run: |
# Test prod build instead of dev.
npm run clean
npm run build
# Note: this modifies package.json to test puppeteer-core, so we test this last.
npm run test:install
Expand All @@ -220,7 +223,7 @@ jobs:
ls .local-chromium
- name: Build
run: |
npm run build:dev
npm run build
docker/pack.sh
- name: Build docker image
working-directory: ./docker
Expand Down