Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify Puppeteer version for Chromium 105.0.5173.0 #8766

Merged
merged 1 commit into from Aug 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/chromium-support.md
Expand Up @@ -8,6 +8,7 @@ The following versions of Chromium are supported, mapped to Puppeteer version:

<!-- version-start -->

- Chromium 105.0.5173.0 - [Puppeteer v15.5.0](https://github.com/puppeteer/puppeteer/blob/v15.5.0/docs/api/index.md)
- Chromium 104.0.5109.0 - Puppeteer v15.1.0
- Chromium 103.0.5059.0 - [Puppeteer v14.2.0](https://github.com/puppeteer/puppeteer/blob/v14.2.0/docs/api.md)
- Chromium 102.0.5002.0 - [Puppeteer v14.0.0](https://github.com/puppeteer/puppeteer/blob/v14.0.0/docs/api.md)
Expand Down
9 changes: 7 additions & 2 deletions utils/generate_docs.ts
Expand Up @@ -19,6 +19,7 @@ import {join} from 'path';
import {chdir} from 'process';
import semver from 'semver';
import {versionsPerRelease} from '../versions.js';
import versionsArchived from '../website/versionsArchived.json';

// eslint-disable-next-line import/extensions
import {generateDocs} from './internal/custom_markdown_action';
Expand Down Expand Up @@ -58,7 +59,7 @@ chdir(join(__dirname, '..'));
---
sidebar_position: 1
---

`;
writeFileSync('docs/index.md', sectionContent + content);
}
Expand All @@ -74,7 +75,11 @@ chdir(join(__dirname, '..'));
if (puppeteerVersion === 'NEXT') {
continue;
}
if (semver.lt(puppeteerVersion, '15.0.0')) {
if (versionsArchived.includes(puppeteerVersion.substring(1))) {
buffer.push(
` * Chromium ${chromiumVersion} - [Puppeteer ${puppeteerVersion}](https://github.com/puppeteer/puppeteer/blob/${puppeteerVersion}/docs/api/index.md)`
);
} else if (semver.lt(puppeteerVersion, '15.0.0')) {
buffer.push(
` * Chromium ${chromiumVersion} - [Puppeteer ${puppeteerVersion}](https://github.com/puppeteer/puppeteer/blob/${puppeteerVersion}/docs/api.md)`
);
Expand Down
2 changes: 1 addition & 1 deletion versions.js
Expand Up @@ -17,7 +17,7 @@
const versionsPerRelease = new Map([
// This is a mapping from Chromium version => Puppeteer version.
// In Chromium roll patches, use 'NEXT' for the Puppeteer version.
['105.0.5173.0', 'NEXT'],
['105.0.5173.0', 'v15.5.0'],
['104.0.5109.0', 'v15.1.0'],
['103.0.5059.0', 'v14.2.0'],
['102.0.5002.0', 'v14.0.0'],
Expand Down