Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address flakiness in frame handling #8688

Merged
merged 1 commit into from Jul 25, 2022

Commits on Jul 25, 2022

  1. fix: address flakiness in frame handling

    When we attach to a frame, we send a call to get
    the page frame tree from CDP. Based on the tree data
    we look up the parent frame if parentId is provided.
    The problem is that the call to get the page frame
    tree could take arbitrary time and the calls for the
    parent and child frames might happen at the same time.
    So the situation where the frame tree for the child frame
    is resolved before the parent frame is known is fairly
    common.
    
    This PR addresses the issue by awaiting for the parent
    frame id before attempting to register a child frame.
    OrKoN committed Jul 25, 2022
    Copy the full SHA
    b6c4b52 View commit details
    Browse the repository at this point in the history