Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): fix page.#scrollIntoViewIfNeeded method #8631

Merged
merged 1 commit into from Jul 8, 2022
Merged

fix(page): fix page.#scrollIntoViewIfNeeded method #8631

merged 1 commit into from Jul 8, 2022

Commits on Jul 8, 2022

  1. fix(page): fix page.#scrollIntoViewIfNeeded method 

    This patch fixes page.#scrollIntoViewIfNeeded, so that it works with devtools protocol.
Now it blocks the main thread and waits until the scrolling action finishes in Chrome.
Fallbacks to the old implementation if `DOM.scrollIntoViewIfNeeded` is not supported for Firefox.

Issues: puppeteer#8627, puppeteer#1805
    @abozhilov @OrKoN
    abozhilov authored and OrKoN committed Jul 8, 2022
    Copy the full SHA
    08045ba View commit details
    Browse the repository at this point in the history