fix: fix fromSurface:false screenshoting #8591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what to do with the shadow in the top of the screenshot... Is it happening because of "Chrome is controlled by a test software" bar? |
|
Don't know why it fails on Linux... Works on Windows. |
LeviPesin
force-pushed
the
fix-browser-bounds
branch
2 times, most recently
from
cd445a0
to
ee44225
Compare
jrandolf
approved these changes
Jun 28, 2022
LeviPesin
force-pushed
the
fix-browser-bounds
branch
2 times, most recently
from
708390a
to
45065c7
Compare
LeviPesin
force-pushed
the
fix-browser-bounds
branch
from
45065c7
to
1bfb579
Compare
|
Will test on Linux and Mac why screenshot differs there... |
|
Closed due to lack of activity. P.S. there have been backend changes in M108/M109. I wonder if it improved the situation somewhat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix.
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes.
Summary
An easy fix to #8496 that I just found.
Does this PR introduce a breaking change?
No.
Other information
Hope it will go in 15.2.0! :-)