Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): Add types to in-page functions like evaluate(Handle), waitForFunction, etc #8540

Closed
wants to merge 1 commit into from
Closed

chore(types): Add types to in-page functions like evaluate(Handle), waitForFunction, etc #8540

wants to merge 1 commit into from

Commits on Jun 21, 2022

  1. chore(types): Add types to in-page functions like evaluate(Handle… 

    …), `waitForFunction`, etc

Issue: puppeteer#8485

BREAKING CHANGE: Functions accepting page functions (e.g. `Page.evaluate`) do not accept strings anymore (except Page.evaluateOnNewDocument). Generic parameters of these functions have changed. Types of these functions are now properly enforced, leading to rejection of improperly typed programs. Some type aliases in `EvalTypes` have been removed.
    @stevenwdv
    stevenwdv committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    36c3c24 View commit details
    Browse the repository at this point in the history