Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use CDP's auto-attach mechanism #8520

Merged
merged 10 commits into from Jul 21, 2022
Merged

feat: use CDP's auto-attach mechanism #8520

merged 10 commits into from Jul 21, 2022

Commits on Jul 21, 2022

  1. feat: use CDP's auto-attach mechanism 

    In this PR, we refactor Puppeteer to make use of CDP's
auto-attach mechanism. This allows the backend to pause
new targets and give Puppeteer a chance to configure them
properly. This fixes the flakiness related to dealing with
OOPIFs and should fix a multitude of issues related to the
network interception and navigations. If those are not fixed
completely by this PR, the PR serves a solid base for fixing them

Closes #8507, #7990
Unlocks #3667

BREAKING CHANGE: With Chromium, Puppeteer will now attach
to page/iframe targets immediately.
BREAKING CHANGE: Browser.connect requires an explicit product name
when connecting to Firefox since Firefox does not support CDP's auto-attach.
    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    e56cd22 View commit details
    Browse the repository at this point in the history

  2. fix: only expect targets that match the filter

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    d979a74 View commit details
    Browse the repository at this point in the history

  3. fix: introduce TargetDiscovered event

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    6038cc4 View commit details
    Browse the repository at this point in the history

  4. chore: remove unsupported events from Firefox

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    e35754d View commit details
    Browse the repository at this point in the history

  5. chore: invoke TargetManager::dispose

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    4e4a93a View commit details
    Browse the repository at this point in the history

  6. chore: try fix docs job

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    22a120f View commit details
    Browse the repository at this point in the history

  7. fix: wait for pages before proceeding with iframes

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    3ad7324 View commit details
    Browse the repository at this point in the history

  8. test: disable a Launcher test in Firefox

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    04995e4 View commit details
    Browse the repository at this point in the history

  9. test: create pages on a context

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    ba9c248 View commit details
    Browse the repository at this point in the history

  10. chore: rename method

    @OrKoN
    OrKoN committed Jul 21, 2022
    Copy the full SHA
    e448453 View commit details
    Browse the repository at this point in the history