Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Firefox compatibility for Windows #7668

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
102 changes: 50 additions & 52 deletions .github/workflows/main.yml
Expand Up @@ -43,36 +43,34 @@ jobs:
run: |
npm run build

- name: Run code checks
run: |
npm run ensure-pinned-deps
npm run lint
# Skipping as it's flakey and we are not currently using the new documentation site in the wild yet.
# See https://github.com/puppeteer/puppeteer/issues/7710 for more info
# npm run generate-docs
npm run ensure-correct-devtools-protocol-revision
npm run test-types-file

- name: Run commit lint
run: |
npm run commitlint
if: github.event_name != 'pull_request'

- name: Run unit tests
uses: nick-invision/retry@v2
env:
CHROMIUM: true
with:
max_attempts: 3
command: xvfb-run --auto-servernum npm run unit
timeout_minutes: 10

- name: Run unit tests with coverage
env:
CHROMIUM: true
run: |
xvfb-run --auto-servernum npm run unit-with-coverage
xvfb-run --auto-servernum npm run assert-unit-coverage
# - name: Run code checks
# run: |
# npm run ensure-pinned-deps
# npm run lint
# npm run generate-docs
# npm run ensure-correct-devtools-protocol-revision
# npm run test-types-file

# - name: Run commit lint
# run: |
# npm run commitlint
# if: github.event_name != 'pull_request'

# - name: Run unit tests
# uses: nick-invision/retry@v2
# env:
# CHROMIUM: true
# with:
# max_attempts: 3
# command: xvfb-run --auto-servernum npm run unit
# timeout_minutes: 10

# - name: Run unit tests with coverage
# env:
# CHROMIUM: true
# run: |
# xvfb-run --auto-servernum npm run unit-with-coverage
# xvfb-run --auto-servernum npm run assert-unit-coverage

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
Expand All @@ -84,18 +82,18 @@ jobs:
timeout_minutes: 10
command: xvfb-run --auto-servernum npm run funit

- name: Run browser tests
run: |
npm run test-browser
# - name: Run browser tests
# run: |
# npm run test-browser

- name: Test bundling and installation
env:
CHROMIUM: true
run: |
# Note: this modifies package.json to test puppeteer-core.
npm run test-install
# Undo those changes.
git checkout --force
# - name: Test bundling and installation
# env:
# CHROMIUM: true
# run: |
# # Note: this modifies package.json to test puppeteer-core.
# npm run test-install
# # Undo those changes.
# git checkout --force

macos:
# https://github.com/actions/virtual-environments#available-environments
Expand Down Expand Up @@ -125,11 +123,11 @@ jobs:
run: |
npm run build

- name: Run unit tests
env:
CHROMIUM: true
run: |
npm run unit
# - name: Run unit tests
# env:
# CHROMIUM: true
# run: |
# npm run unit

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
Expand Down Expand Up @@ -168,18 +166,18 @@ jobs:
run: |
npm run build

- name: Run unit tests
env:
CHROMIUM: true
run: |
npm run unit
# - name: Run unit tests
# env:
# CHROMIUM: true
# run: |
# npm run unit

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
continue-on-error: true
env:
FIREFOX: true
MOZ_WEBRENDER: 0
DEBUG: puppeteer.*
with:
max_attempts: 3
timeout_minutes: 10
Expand Down
3 changes: 2 additions & 1 deletion test/evaluation.spec.ts
Expand Up @@ -383,7 +383,8 @@ describe('Evaluation specs', function () {
expect(result).toEqual([42]);
}
);
it('should transfer 100Mb of data from page to node.js', async function () {
// eslint-disable-next-line mocha/no-exclusive-tests
it.only('should transfer 100Mb of data from page to node.js', async function () {
const { page } = getTestState();

const a = await page.evaluate<() => string>(() =>
Expand Down