Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable followRedirects for NodeWebSocket #7555

Merged
merged 1 commit into from Sep 10, 2021
Merged

chore: enable followRedirects for NodeWebSocket #7555

merged 1 commit into from Sep 10, 2021

Conversation

theomessin
Copy link
Contributor

I'm building a cluster of Chromium browsers that is load balanced using redirects.
Since puppeteer.connect uses the ws library under the hood, it'd be nice if we followed redirects.
ws has supported following redirects this for a while now: websockets/ws#1490

This PR simply enables the followRedirects option when constructing the WebSocket in .connect.

@google-cla
Copy link

google-cla bot commented Sep 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@jschfflr jschfflr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jschfflr jschfflr enabled auto-merge (squash) September 10, 2021 11:17
auto-merge was automatically disabled September 10, 2021 12:45

Head branch was pushed to by a user without write access

@theomessin
Copy link
Contributor Author

@jschfflr Just changed the commit message to satisfy commitlint. Can you please re-enable the workflows? 😄

@jschfflr
Copy link
Contributor

@jschfflr Just changed the commit message to satisfy commitlint. Can you please re-enable the workflows? 😄

Sure :)

@jschfflr jschfflr merged commit 5735f31 into puppeteer:main Sep 10, 2021
@theomessin theomessin deleted the patch-1 branch September 10, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants