chore: skip non-standard cookie asserts on Firefox

[juliandescottes]

Fix for #6976

This change adds a dedicated assert helper for cookies which will only check the non-standard properties sameParty, sourcePort and sourceScheme when running against chrome.

All cookie asserts are replaced to use this helper.

3 tests marked as failing with Firefox are enabled:

• Page.cookies should get a cookie
• Page.cookies should get multiple cookies
• DefaultBrowserContext page.cookies() should work

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[jschfflr]

What do you think about changing this to check to only checking the standard properties instead of removing the non standard ones?

[juliandescottes]

Thanks for the review! Tried to keep it simple and just copied over all the standard/shared values to a new object. Let me know if you had something else in mind.

[juliandescottes]

@googlebot I signed it!

[juliandescottes]

A test failed at https://github.com/puppeteer/puppeteer/pull/6994/checks?check_run_id=2114890609
Looks like the failing tests are:

  Workers
    1) "before all" hook for "Page.workers"
    2) "after all" hook for "should report errors"

Any chance this could be an intermittent failure or is it really something my patch broke?

[whimboo]

I triggered a re-run of all the jobs. Lets see...

[whimboo]

All the checks passed this time.

[jschfflr]

Yes, this is what I had in mind. Now, you should also be able to remove the isChrome branch.

[juliandescottes]

Yes, this is what I had in mind. Now, you should also be able to remove the isChrome branch.

Sorry, I don't have a isChrome branch in the current patch. Are you referring to the change in test/mocha-utils.ts or to something else?

[juliandescottes]

Thanks for merging @jschfflr !
I was ok with updating the patch, and would have done so later today. I hope you're fine with the version you merged. If not, I'm really happy to provide another patch.

[jschfflr]

Sorry for the late reply - I was OOO. No, I'm more than happy with the current version. Thanks!