Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add latest chromium version #6952

Merged

Conversation

theDavidBarton
Copy link
Contributor

In v8.0.0 the Chromium roll to r856583 was not registered to docs/api.md and versions.js.
Now it is done retrospectively.

Follow up to: #6927

@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@theDavidBarton theDavidBarton changed the title Add missing chromium version chore: add latest chromium version Mar 3, 2021
@mathiasbynens
Copy link
Member

Good catch! Looks like we forgot about step 5 in #6927 (FYI @OrKoN) and I missed it during review. I wonder if we should move the step around so it's more visible/to the top?

@mathiasbynens mathiasbynens merged commit abb3280 into puppeteer:main Mar 4, 2021
@OrKoN
Copy link
Collaborator

OrKoN commented Mar 4, 2021

Looks like I have missed that step. Thanks for fixing this!

@theDavidBarton
Copy link
Contributor Author

I have an opened pr (puppeteer/pptr.dev#22) that is related to rolling-new-chromium-version. The problem is pptr.dev fails to parse the Chromium version rolls anymore as the format of these announcements has changed over time in the release notes.

The issue is explained in puppeteer/pptr.dev#20.

@mathiasbynens do you see any chance that the pull requests on puppeteer/pptr.dev will be reviewed in the near future?

I plan to make a suggestion to CONTRIBUTING.md in a pr soon, so the versions would be displayed properly on the docs site. But poor pptr.dev is an orphan child at the moment 😅 hope it will get an update sometime 😃 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants