Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r856583 #6927

Merged
merged 2 commits into from Feb 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -54,7 +54,7 @@
"license": "Apache-2.0",
"dependencies": {
"debug": "^4.1.0",
"devtools-protocol": "0.0.847576",
"devtools-protocol": "0.0.854822",
"extract-zip": "^2.0.0",
"https-proxy-agent": "^5.0.0",
"node-fetch": "^2.6.1",
Expand Down
2 changes: 1 addition & 1 deletion src/revisions.ts
Expand Up @@ -20,6 +20,6 @@ type Revisions = Readonly<{
}>;

export const PUPPETEER_REVISIONS: Revisions = {
chromium: '848005',
chromium: '856583',
firefox: 'latest',
};
22 changes: 22 additions & 0 deletions test/cookies.spec.ts
Expand Up @@ -49,6 +49,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 8907,
sourceScheme: 'NonSecure',
},
]);
});
Expand Down Expand Up @@ -106,6 +108,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 8907,
sourceScheme: 'NonSecure',
},
{
name: 'username',
Expand All @@ -118,6 +122,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 8907,
sourceScheme: 'NonSecure',
},
]);
});
Expand Down Expand Up @@ -154,6 +160,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: true,
session: true,
sourcePort: 443,
sourceScheme: 'Secure',
},
{
name: 'doggo',
Expand All @@ -166,6 +174,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: true,
session: true,
sourcePort: 443,
sourceScheme: 'Secure',
},
]);
});
Expand Down Expand Up @@ -259,6 +269,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);
});
Expand All @@ -283,6 +295,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);
expect(await page.evaluate('document.cookie')).toBe('gridcookie=GRID');
Expand Down Expand Up @@ -389,6 +403,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: true,
session: true,
sourcePort: 443,
sourceScheme: 'Secure',
},
]);
});
Expand Down Expand Up @@ -428,6 +444,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);

Expand All @@ -443,6 +461,8 @@ describe('Cookie specs', () => {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);
});
Expand Down Expand Up @@ -496,6 +516,8 @@ describe('Cookie specs', () => {
sameSite: 'None',
secure: true,
session: true,
sourcePort: 443,
sourceScheme: 'Secure',
},
]);
} finally {
Expand Down
6 changes: 6 additions & 0 deletions test/defaultbrowsercontext.spec.ts
Expand Up @@ -43,6 +43,8 @@ describe('DefaultBrowserContext', function () {
httpOnly: false,
secure: false,
session: true,
sourcePort: 8907,
sourceScheme: 'NonSecure',
},
]);
});
Expand All @@ -69,6 +71,8 @@ describe('DefaultBrowserContext', function () {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);
});
Expand Down Expand Up @@ -101,6 +105,8 @@ describe('DefaultBrowserContext', function () {
httpOnly: false,
secure: false,
session: true,
sourcePort: 80,
sourceScheme: 'NonSecure',
},
]);
});
Expand Down