Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run unit tests for Firefox on MacOS #6896

Merged
merged 2 commits into from Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
Expand Up @@ -113,6 +113,13 @@ jobs:
run: |
npm run unit
- name: Run unit tests on Firefox
env:
FIREFOX: true
MOZ_WEBRENDER: 0
run: |
npm run funit
windows:
# https://github.com/actions/virtual-environments#available-environments
runs-on: windows-latest
Expand Down
2 changes: 1 addition & 1 deletion test/keyboard.spec.ts
Expand Up @@ -127,7 +127,7 @@ describe('Keyboard', function () {
await page.evaluate(() => document.querySelector('textarea').value)
).toBe('嗨a');
});
it('should report shiftKey', async () => {
itFailsFirefox('should report shiftKey', async () => {
whimboo marked this conversation as resolved.
Show resolved Hide resolved
const { page, server } = getTestState();

await page.goto(server.PREFIX + '/input/keyboard.html');
Expand Down