fix: jsonValue() type is generic #6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the migration to TS we changed `jsonValue` so it returned `<Record<string, unknown>>`. This is only true if all the JSON values it returns are objects; but it could return an array, a string, a number, etc. Therefore we make the type generic, setting the default to `unknown`, so the user has control over the type.
|
Test failures look like FF, which #6864 should resolve for now |
mathiasbynens
approved these changes
Feb 11, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration to TS we changed
jsonValueso it returned<Record<string, unknown>>. This is only true if all the JSON values itreturns are objects; but it could return an array, a string, a number,
etc. Therefore we make the type generic, setting the default to
unknown, so the user has control over the type.