Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agnostification): common/helper.ts #6515

Merged
merged 3 commits into from
Oct 19, 2020
Merged

chore(agnostification): common/helper.ts #6515

merged 3 commits into from
Oct 19, 2020

Commits on Oct 16, 2020

  1. chore(agnostification): common/helper.ts 

    The `readProtocolStream` method uses `fs` only if you want to write to a
file. So we gate at the start of the function and ensure that if we got
given a path we are not in a Node environment.

We then use `import('fs')` to lazily load fs. We have multiple calls but
they will be cached so I don't believe that it's going to be a perf hit.
    @jackfranklin
    jackfranklin committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    fe8f6cf View commit details
    Browse the repository at this point in the history

  2. chore: fix travis tests

    @jackfranklin
    jackfranklin committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    e84c224 View commit details
    Browse the repository at this point in the history

  3. chore: upgrade test-runner

    @jackfranklin
    jackfranklin committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    7f241ed View commit details
    Browse the repository at this point in the history