Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agnostification): split up root Puppeteer class #6504

Merged
merged 1 commit into from
Oct 13, 2020

Commits on Oct 13, 2020

  1. chore(agnostification): split up root Puppeteer class

    The `Puppeteer` class had two concerns:
    
    * connect to an existing browser
    * launch a new browser
    
    The first of those concerns is needed in all environments, but the
    second is only needed in Node.
    #6484 landing enabled us to
    pull the `Puppeteer` class apart into two:
    
    1. `Puppeteer` which hosts the behaviour for connecting to existing
       browsers.
    2. `PuppeteerNode`, which extends `Puppeteer` and also adds the ability
       to launch a new browser.
    
    This is a non-breaking change, because Node users will still get an
    instance of a class with all the methods they expect, but it'll be a
    `PuppeteerNode` rather than `Puppeteer`. I don't expect this to cause
    people any issues.
    
    We also now have new files that are effectively the entry points for
    Puppeteer:
    
    * `node.ts`: the main entry point for Puppeteer on Node.
    * `web.ts`: the main entry point for Puppeteer on the web.
    * `node-puppeteer-core.ts`: for those using puppeteer-core (which only
      exists in Node, not on the web).
    jackfranklin committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    c6ad697 View commit details
    Browse the repository at this point in the history