New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chromium): roll Chromium to r782078 #6250
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3301758
fix paths in check_availability.js
johanbay 23c0a50
feat(chromium): roll Chromium to 782078
johanbay c05a5dd
fix unit test for crrev.com/c/2231445
johanbay 39f869d
fix unit test for crrev.com/c/2216595
johanbay 5169f79
update docs
johanbay File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,8 @@ | |
const assert = require('assert'); | ||
const https = require('https'); | ||
// run `npm run dev-install` if lib dir is missing | ||
const BrowserFetcher = require('../lib/cjs/node/BrowserFetcher').BrowserFetcher; | ||
const BrowserFetcher = require('../lib/cjs/puppeteer/node/BrowserFetcher.js') | ||
.BrowserFetcher; | ||
|
||
const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64']; | ||
const fetchers = SUPPORTER_PLATFORMS.map( | ||
|
@@ -163,7 +164,7 @@ async function checkRollCandidate() { | |
10 | ||
); | ||
const currentRevision = parseInt( | ||
require('../lib/cjs/revisions').PUPPETEER_REVISIONS.chromium, | ||
require('../lib/cjs/puppeteer/revisions').PUPPETEER_REVISIONS.chromium, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah sorry I missed these when I did the restructure; thank you for fixing 👍 |
||
10 | ||
); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now these two
expect
calls are the same, I think we can lose the conditional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
width
is different though?